Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tidy up deps for common package #123

Merged
merged 2 commits into from
May 19, 2024
Merged

Tidy up deps for common package #123

merged 2 commits into from
May 19, 2024

Conversation

stwiname
Copy link
Contributor

Description

Removed dependencies from common-algorand that are already specified in common. Moved the required ones to peer-deps. This should reduce some warnings when installing the CLI.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have tested locally
  • I have performed a self review of my changes
  • Updated any relevant documentation
  • Linked to any relevant issues
  • I have added tests relevant to my changes
  • Any dependent changes have been merged and published in downstream modules
  • My code is up to date with the base branch
  • I have updated relevant changelogs. We suggest using chan

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 19, 2024 •
edited
Loading

Coverage report

Caution

Test run failed

St.❔
 Category Percentage Covered / Total
🔴 Statements 32.61% 1062/3257
🔴 Branches 53.85% 56/104
🔴 Functions 22.05% 28/127
🔴 Lines 32.61% 1062/3257

Test suite run failed

Failed tests: 1/16. Failed suites: 1/4. 
  ● ApiService › waits on pending block to fetch hash

    expect(received).toBeDefined()

    Received: undefined

      86 |
      87 |     const block = await fetchLatestBlock();
    > 88 |     expect(block.block.hash).toBeDefined();
         |                              ^
      89 |   });
      90 | });
      91 |

      at Object.<anonymous> (packages/node/src/indexer/api.service.spec.ts:88:30)

Report generated by 🧪jest coverage report action from 797a2c0

@stwiname stwiname merged commit ec544ba into main May 19, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiqiang90 jiqiang90 jiqiang90 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stwiname @jiqiang90